Release client and server #260
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds release automation for client and server components by configuring JReleaser and adding a GitHub Actions workflow for publishing to Maven Central Portal.
- Configures JReleaser with GitHub release settings that skip tag/release creation
- Adds a GitHub Actions workflow for building and publishing client and server modules
- Sets up automated publication to Maven Central with proper GPG signing and authentication
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| buildSrc/src/main/kotlin/mcp.jreleaser.gradle.kts | Adds GitHub release configuration to skip tagging and release creation |
| .github/workflows/publish-client-and-server.yml | New workflow for automated publishing of client and server to Maven Central |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| skipRelease = true | ||
| skipTag = true | ||
| overwrite = false | ||
| token = "none" |
There was a problem hiding this comment.
Using a hardcoded 'none' token value could cause authentication issues. Consider using a proper environment variable or removing this line if GitHub token authentication is handled elsewhere.
| token = "none" | |
| token = System.getenv("GITHUB_TOKEN") |
| GPG_SECRET_KEY: ${{ secrets.GPG_SECRET_KEY }} | ||
| SIGNING_PASSPHRASE: ${{ secrets.SIGNING_PASSPHRASE }} |
There was a problem hiding this comment.
These environment variables duplicate the JRELEASER_GPG_SECRET_KEY and JRELEASER_GPG_PASSPHRASE variables already set above. Consider removing the duplicates to reduce configuration redundancy.
| JRELEASER_GPG_PASSPHRASE: ${{ secrets.SIGNING_PASSPHRASE }} | ||
| JRELEASER_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GPG_SECRET_KEY: ${{ secrets.GPG_SECRET_KEY }} | ||
| SIGNING_PASSPHRASE: ${{ secrets.SIGNING_PASSPHRASE }} |
There was a problem hiding this comment.
These environment variables are duplicated again in the publish step. The JRELEASER_* prefixed versions should be sufficient for JReleaser operations.
| SIGNING_PASSPHRASE: ${{ secrets.SIGNING_PASSPHRASE }} |
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context